From e72e16d97ccd8f4d0fe70e27cf38e8d5f8f1b6d3 Mon Sep 17 00:00:00 2001
From: Ruslan Bayandinov <45530296+wazsone@users.noreply.github.com>
Date: Tue, 6 Jun 2023 17:07:05 +0700
Subject: [PATCH] fix activity filters bugs (#3341)

Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru>
---
 .../src/components/ActivityFilter.svelte      | 45 +++++++++++--------
 .../src/components/FilterPopup.svelte         | 24 +++++-----
 2 files changed, 39 insertions(+), 30 deletions(-)

diff --git a/plugins/activity-resources/src/components/ActivityFilter.svelte b/plugins/activity-resources/src/components/ActivityFilter.svelte
index cb4cec927f..d6bac5a151 100644
--- a/plugins/activity-resources/src/components/ActivityFilter.svelte
+++ b/plugins/activity-resources/src/components/ActivityFilter.svelte
@@ -15,7 +15,7 @@
 <script lang="ts">
   import activity, { ActivityFilter, DisplayTx } from '@hcengineering/activity'
   import { Class, Doc, Ref } from '@hcengineering/core'
-  import { IntlString, getResource } from '@hcengineering/platform'
+  import { getResource } from '@hcengineering/platform'
   import { getClient, hasResource } from '@hcengineering/presentation'
   import { ActionIcon, AnyComponent, Icon, Label, eventToHTMLElement, showPopup } from '@hcengineering/ui'
   import { createEventDispatcher } from 'svelte'
@@ -31,20 +31,21 @@
   const client = getClient()
   let filters: ActivityFilter[] = []
   const saved = localStorage.getItem('activity-filter')
-  let selectedFilter: Ref<Doc>[] | 'All' =
+  let selectedFiltersRefs: Ref<Doc>[] | 'All' =
     saved !== null && saved !== undefined ? (JSON.parse(saved) as Ref<Doc>[] | 'All') : 'All'
-  $: localStorage.setItem('activity-filter', JSON.stringify(selectedFilter))
+  let selectedFilters: ActivityFilter[] = []
+  $: localStorage.setItem('activity-filter', JSON.stringify(selectedFiltersRefs))
   client.findAll(activity.class.ActivityFilter, {}).then((res) => {
     filters = res
     if (saved !== null && saved !== undefined) {
       const temp: Ref<Doc>[] | 'All' = JSON.parse(saved)
       if (temp !== 'All' && Array.isArray(temp)) {
-        selectedFilter = temp.filter((it) => filters.findIndex((f) => it === f._id) > -1)
-        if ((selectedFilter as Ref<Doc>[]).length === 0) {
-          selectedFilter = 'All'
+        selectedFiltersRefs = temp.filter((it) => filters.findIndex((f) => it === f._id) > -1)
+        if ((selectedFiltersRefs as Ref<Doc>[]).length === 0) {
+          selectedFiltersRefs = 'All'
         }
       } else {
-        selectedFilter = 'All'
+        selectedFiltersRefs = 'All'
       }
     }
   })
@@ -65,17 +66,18 @@
   const handleOptions = (ev: MouseEvent) => {
     showPopup(
       FilterPopup,
-      { selectedFilter, filters },
+      { selectedFiltersRefs, filters },
       eventToHTMLElement(ev),
       () => {},
       (res) => {
         if (res === undefined) return
-        if (res.action === 'select') selectedFilter = res.value as Ref<Doc>[] | 'All'
+        const selected = res.value as Ref<Doc>[]
+        const isAll = selected.length === filters.length || selected.length === 0
+        if (res.action === 'select') selectedFiltersRefs = isAll ? 'All' : selected
       }
     )
   }
 
-  let labels: IntlString[] = []
   const dispatch = createEventDispatcher()
 
   async function updateFilterActions (
@@ -87,11 +89,9 @@
       filtered = txes
       dispatch('update', filtered)
     } else {
-      const selectedFilters = filters.filter((filter) => selected.includes(filter._id))
+      selectedFilters = filters.filter((filter) => selected.includes(filter._id))
       const filterActions: ((tx: DisplayTx, _class?: Ref<Doc>) => boolean)[] = []
-      labels = []
       for (const filter of selectedFilters) {
-        labels.push(filter.label)
         const fltr = await getResource(filter.filter)
         filterActions.push(fltr)
       }
@@ -100,18 +100,27 @@
     }
   }
 
-  $: updateFilterActions(txes, filters, selectedFilter)
+  $: updateFilterActions(txes, filters, selectedFiltersRefs)
 </script>
 
-{#if selectedFilter === 'All'}
+{#if selectedFiltersRefs === 'All'}
   <div class="antiSection-header__tag highlight">
     <Label label={activityPlg.string.All} />
   </div>
 {:else}
-  {#each labels as label}
+  {#each selectedFilters as filter}
     <div class="antiSection-header__tag overflow-label">
-      <Label {label} />
-      <div class="tag-icon">
+      <Label label={filter.label} />
+      <!-- svelte-ignore a11y-click-events-have-key-events -->
+      <div
+        class="tag-icon"
+        on:click={() => {
+          if (selectedFiltersRefs !== 'All') {
+            const ids = selectedFiltersRefs.filter((it) => it !== filter._id)
+            selectedFiltersRefs = ids.length > 0 ? ids : 'All'
+          }
+        }}
+      >
         <Icon icon={IconClose} size={'small'} />
       </div>
     </div>
diff --git a/plugins/activity-resources/src/components/FilterPopup.svelte b/plugins/activity-resources/src/components/FilterPopup.svelte
index 3c65778530..de0b289edd 100644
--- a/plugins/activity-resources/src/components/FilterPopup.svelte
+++ b/plugins/activity-resources/src/components/FilterPopup.svelte
@@ -20,7 +20,7 @@
   import { ActivityFilter } from '@hcengineering/activity'
   import activity from '../plugin'
 
-  export let selectedFilter: Ref<Doc>[] | 'All' = 'All'
+  export let selectedFiltersRefs: Ref<Doc>[] | 'All' = 'All'
   export let filters: ActivityFilter[] = []
 
   const dispatch = createEventDispatcher()
@@ -38,8 +38,8 @@
     }
   ]
   filters.map((fl) => menu.push({ label: fl.label, checked: false, value: fl._id }))
-  if (selectedFilter !== 'All') {
-    selectedFilter.forEach((fl) => {
+  if (selectedFiltersRefs !== 'All') {
+    selectedFiltersRefs.forEach((fl) => {
       const index = menu.findIndex((el) => el.value === fl)
       if (index !== -1) menu[index].checked = true
     })
@@ -76,35 +76,35 @@
 
   const checkAll = () => {
     menu.forEach((el, i) => (el.checked = i === 0))
-    selectedFilter = 'All'
+    selectedFiltersRefs = 'All'
   }
   const uncheckAll = () => {
     menu.forEach((el) => (el.checked = true))
     const temp = filters.map((fl) => fl._id as Ref<Doc>)
-    selectedFilter = temp
+    selectedFiltersRefs = temp
   }
 
   const selectRow = (n: number) => {
     if (n === 0) {
-      if (selectedFilter === 'All') uncheckAll()
+      if (selectedFiltersRefs === 'All') uncheckAll()
       else checkAll()
     } else {
-      if (selectedFilter === 'All') {
+      if (selectedFiltersRefs === 'All') {
         menu[n].checked = true
-        selectedFilter = [menu[n].value as Ref<Doc>]
+        selectedFiltersRefs = [menu[n].value as Ref<Doc>]
       } else if (menu[n].checked) {
         if (menu.filter((el) => el.checked).length === 2) checkAll()
         else {
           menu[n].checked = false
-          selectedFilter = selectedFilter.filter((fl) => fl !== menu[n].value)
+          selectedFiltersRefs = selectedFiltersRefs.filter((fl) => fl !== menu[n].value)
         }
       } else {
         menu[n].checked = true
-        selectedFilter.push(menu[n].value as Ref<Doc>)
+        selectedFiltersRefs.push(menu[n].value as Ref<Doc>)
       }
     }
     menu = menu
-    dispatch('update', { action: 'select', value: selectedFilter })
+    dispatch('update', { action: 'select', value: selectedFiltersRefs })
     setTimeout(() => dispatch('changeContent'), 0)
   }
 
@@ -137,7 +137,7 @@
           on:click={() => selectRow(i)}
         >
           <div class="flex-center justify-end mr-3 pointer-events-none">
-            <CheckBox checked={item.checked} symbol={selectedFilter !== 'All' && i === 0 ? 'minus' : 'check'} />
+            <CheckBox checked={item.checked} symbol={selectedFiltersRefs !== 'All' && i === 0 ? 'minus' : 'check'} />
           </div>
           <span class="overflow-label">
             <Label label={item.label} />