From e43783da94955ba1688a5c181d4283d23e41d729 Mon Sep 17 00:00:00 2001
From: Denis Bykhov <bykhov.denis@gmail.com>
Date: Thu, 4 Jan 2024 16:37:11 +0600
Subject: [PATCH] UBERF-4815 (#4299)

* UBERF-4815

Signed-off-by: Denis Bykhov <bykhov.denis@gmail.com>

* Fix

Signed-off-by: Denis Bykhov <bykhov.denis@gmail.com>

* Fix formatting

Signed-off-by: Denis Bykhov <bykhov.denis@gmail.com>

* Fix

Signed-off-by: Denis Bykhov <bykhov.denis@gmail.com>

---------

Signed-off-by: Denis Bykhov <bykhov.denis@gmail.com>
---
 packages/presentation/src/configuration.ts         |  8 +++++---
 .../projectTypes/CreateProjectType.svelte          |  8 ++++++--
 .../components/projectTypes/ManageProjects.svelte  |  5 +++--
 .../src/components/taskTypes/CreateTaskType.svelte |  9 ++++++---
 .../view-resources/src/components/EditDoc.svelte   |  6 ++++--
 .../src/components/ViewletSetting.svelte           |  6 +++++-
 plugins/view-resources/src/utils.ts                | 14 ++++++++++----
 7 files changed, 39 insertions(+), 17 deletions(-)

diff --git a/packages/presentation/src/configuration.ts b/packages/presentation/src/configuration.ts
index 359eaf2d67..5b95f522fb 100644
--- a/packages/presentation/src/configuration.ts
+++ b/packages/presentation/src/configuration.ts
@@ -32,11 +32,13 @@ export class ConfigurationManager {
     return this.configuration.get(plugin)?.enabled !== false
   }
 
-  hasResource<T>(resource?: Resource<T> | null): boolean {
+  hasResource<T>(resource?: Resource<T> | null): boolean | undefined {
     if (resource == null) {
       return false
     }
-    return this.has(getResourcePlugin(resource))
+    try {
+      return this.has(getResourcePlugin(resource))
+    } catch {}
   }
 }
 // Issue status live query
@@ -51,7 +53,7 @@ let workspaceId: string = ''
 /**
  * @public
  */
-export function hasResource<T> (resource?: Resource<T>): boolean {
+export function hasResource<T> (resource?: Resource<T>): boolean | undefined {
   return configuration.hasResource(resource)
 }
 
diff --git a/plugins/task-resources/src/components/projectTypes/CreateProjectType.svelte b/plugins/task-resources/src/components/projectTypes/CreateProjectType.svelte
index 501bd440c1..df8c01d5f1 100644
--- a/plugins/task-resources/src/components/projectTypes/CreateProjectType.svelte
+++ b/plugins/task-resources/src/components/projectTypes/CreateProjectType.svelte
@@ -15,11 +15,12 @@
 
 <script lang="ts">
   import { Ref, generateId } from '@hcengineering/core'
-  import { Card, getClient } from '@hcengineering/presentation'
+  import { Card, getClient, hasResource } from '@hcengineering/presentation'
   import { ProjectTypeDescriptor, createProjectType } from '@hcengineering/task'
   import { DropdownLabelsIntl, EditBox, ToggleWithLabel } from '@hcengineering/ui'
   import { createEventDispatcher } from 'svelte'
   import task from '../../plugin'
+  import { Resource } from '@hcengineering/platform'
 
   const client = getClient()
 
@@ -49,7 +50,10 @@
     dispatch('close')
   }
 
-  const descriptors = client.getModel().findAllSync(task.class.ProjectTypeDescriptor, {})
+  const descriptors = client
+    .getModel()
+    .findAllSync(task.class.ProjectTypeDescriptor, {})
+    .filter((p) => hasResource(p._id as any as Resource<any>))
   const items = descriptors.map((it) => ({
     label: it.name,
     id: it._id
diff --git a/plugins/task-resources/src/components/projectTypes/ManageProjects.svelte b/plugins/task-resources/src/components/projectTypes/ManageProjects.svelte
index 36f3c9f983..ba4a7dd852 100644
--- a/plugins/task-resources/src/components/projectTypes/ManageProjects.svelte
+++ b/plugins/task-resources/src/components/projectTypes/ManageProjects.svelte
@@ -18,9 +18,10 @@
   import task, { ProjectType } from '@hcengineering/task'
   import { Location, getCurrentResolvedLocation, navigate, resolvedLocationStore } from '@hcengineering/ui'
 
-  import { createQuery } from '@hcengineering/presentation'
+  import { createQuery, hasResource } from '@hcengineering/presentation'
   import { onDestroy } from 'svelte'
   import Types from './Types.svelte'
+  import { Resource } from '@hcengineering/platform'
 
   export let kind: 'navigation' | 'tools' | undefined
   export let categoryName: string
@@ -50,7 +51,7 @@
     task.class.ProjectType,
     { archived: false },
     (result) => {
-      types = result
+      types = result.filter((p) => hasResource(p.descriptor as any as Resource<any>))
     },
     {
       lookup: {
diff --git a/plugins/task-resources/src/components/taskTypes/CreateTaskType.svelte b/plugins/task-resources/src/components/taskTypes/CreateTaskType.svelte
index 1ea9eae655..5d01036b75 100644
--- a/plugins/task-resources/src/components/taskTypes/CreateTaskType.svelte
+++ b/plugins/task-resources/src/components/taskTypes/CreateTaskType.svelte
@@ -14,8 +14,8 @@
 -->
 <script lang="ts">
   import core, { Class, ClassifierKind, Data, Ref, RefTo, Status, generateId, toIdMap } from '@hcengineering/core'
-  import { getEmbeddedLabel } from '@hcengineering/platform'
-  import presentation, { Card, getClient } from '@hcengineering/presentation'
+  import { Resource, getEmbeddedLabel } from '@hcengineering/platform'
+  import presentation, { Card, getClient, hasResource } from '@hcengineering/presentation'
   import {
     ProjectType,
     ProjectTypeDescriptor,
@@ -57,7 +57,10 @@
     }
   }
 
-  const taskTypeDescriptors = client.getModel().findAllSync(task.class.TaskTypeDescriptor, { allowCreate: true })
+  const taskTypeDescriptors = client
+    .getModel()
+    .findAllSync(task.class.TaskTypeDescriptor, { allowCreate: true })
+    .filter((p) => hasResource(p._id as any as Resource<any>))
 
   let { kind, name, targetClass, statusCategories, statuses, allowedAsChildOf } =
     taskType !== undefined ? { ...taskType } : { ...defaultTaskType(type) }
diff --git a/plugins/view-resources/src/components/EditDoc.svelte b/plugins/view-resources/src/components/EditDoc.svelte
index f88289cb7e..808494ae5a 100644
--- a/plugins/view-resources/src/components/EditDoc.svelte
+++ b/plugins/view-resources/src/components/EditDoc.svelte
@@ -219,8 +219,10 @@
   }
 
   async function getHeaderEditor (_class: Ref<Class<Doc>>): Promise<AnyComponent | undefined> {
-    const editorMixin = hierarchy.classHierarchyMixin(_class, view.mixin.ObjectEditorHeader, (m) =>
-      hasResource(m.editor)
+    const editorMixin = hierarchy.classHierarchyMixin(
+      _class,
+      view.mixin.ObjectEditorHeader,
+      (m) => hasResource(m.editor) ?? false
     )
     return editorMixin?.editor
   }
diff --git a/plugins/view-resources/src/components/ViewletSetting.svelte b/plugins/view-resources/src/components/ViewletSetting.svelte
index 76a0cec588..5fe70528a2 100644
--- a/plugins/view-resources/src/components/ViewletSetting.svelte
+++ b/plugins/view-resources/src/components/ViewletSetting.svelte
@@ -176,7 +176,11 @@
         : category === 'collection'
           ? view.mixin.CollectionPresenter
           : view.mixin.AttributePresenter
-    const presenter = hierarchy.classHierarchyMixin(attrClass, mixin, (m) => hasResource(m.presenter))?.presenter
+    const presenter = hierarchy.classHierarchyMixin(
+      attrClass,
+      mixin,
+      (m) => hasResource(m.presenter) ?? false
+    )?.presenter
     if (presenter === undefined) return
     const clazz = hierarchy.getClass(attribute.attributeOf)
     const extraProps = viewlet.configOptions?.extraProps
diff --git a/plugins/view-resources/src/utils.ts b/plugins/view-resources/src/utils.ts
index 19ef424020..503b486bdc 100644
--- a/plugins/view-resources/src/utils.ts
+++ b/plugins/view-resources/src/utils.ts
@@ -103,7 +103,11 @@ export async function getObjectPresenter (
   const mixin = isCollectionAttr ? view.mixin.CollectionPresenter : view.mixin.ObjectPresenter
   const clazz = hierarchy.getClass(_class)
 
-  const presenterMixin = hierarchy.classHierarchyMixin(_class, mixin, (m) => !checkResource || hasResource(m.presenter))
+  const presenterMixin = hierarchy.classHierarchyMixin(
+    _class,
+    mixin,
+    (m) => !checkResource || hasResource(m.presenter) === true
+  )
   if (presenterMixin?.presenter === undefined) {
     console.error(
       `object presenter not found for class=${_class}, mixin=${mixin}, preserve key ${JSON.stringify(preserveKey)}`
@@ -895,8 +899,10 @@ export async function getObjectLinkFragment (
   props: Record<string, any> = {},
   component: AnyComponent = view.component.EditDoc
 ): Promise<Location> {
-  const provider = hierarchy.classHierarchyMixin(Hierarchy.mixinOrClass(object), view.mixin.LinkProvider, (m) =>
-    hasResource(m.encode)
+  const provider = hierarchy.classHierarchyMixin(
+    Hierarchy.mixinOrClass(object),
+    view.mixin.LinkProvider,
+    (m) => hasResource(m.encode) ?? false
   )
   if (provider?.encode !== undefined) {
     const f = await getResource(provider.encode)
@@ -906,7 +912,7 @@ export async function getObjectLinkFragment (
     }
   }
   const loc = getCurrentResolvedLocation()
-  if (hasResource(component)) {
+  if (hasResource(component) === true) {
     loc.fragment = getPanelURI(component, object._id, Hierarchy.mixinOrClass(object), 'content')
   }
   return loc