From b73e5340f7bb2df280e412f57fc56fddcad462d2 Mon Sep 17 00:00:00 2001 From: Alexander Platov Date: Tue, 5 Sep 2023 18:16:27 +0300 Subject: [PATCH] UBER-795: replacing the Panel with a Dialog, fix circle button in Kanban. (#3659) Signed-off-by: Alexander Platov --- packages/theme/styles/_layouts.scss | 4 + packages/theme/styles/common.scss | 8 +- packages/theme/styles/components.scss | 2 +- packages/theme/styles/dialogs.scss | 56 ++++++++ packages/ui/src/components/Dialog.svelte | 71 +--------- .../src/components/Chats.svelte | 94 ++++++------ .../src/components/FullMessage.svelte | 119 ++++++---------- .../src/components/Main.svelte | 21 ++- .../src/components/Message.svelte | 8 +- .../src/components/NewMessage.svelte | 134 ++++++++---------- .../src/components/Chat.svelte | 44 +++--- .../src/components/Message.svelte | 2 +- .../src/components/SharedMessages.svelte | 6 +- 13 files changed, 257 insertions(+), 312 deletions(-) diff --git a/packages/theme/styles/_layouts.scss b/packages/theme/styles/_layouts.scss index 67ce2149a6..53df636040 100644 --- a/packages/theme/styles/_layouts.scss +++ b/packages/theme/styles/_layouts.scss @@ -534,6 +534,7 @@ input.search { .pl-8 { padding-left: 2rem; } .pl-9 { padding-left: 2.25rem; } .pl-10 { padding-left: 2.5rem; } +.pl-12 { padding-left: 3rem; } .pr-1 { padding-right: .25rem; } .pr-2 { padding-right: .5rem; } .pr-3 { padding-right: .75rem; } @@ -580,6 +581,7 @@ input.search { .step-lr75 + .step-lr75 { margin-left: .75rem; } .step-tb25 + .step-tb25 { margin-top: .25rem; } .step-tb375 + .step-tb375 { margin-top: .375rem; } +.step-tb5 + .step-tb5 { margin-top: .5rem; } .step-tb75 + .step-tb75 { margin-top: .75rem; } .step-tb-6 + .step-tb-6 { margin-top: 1.5rem; } .step-tb-12 + .step-tb-12 { margin-top: 3rem; } @@ -686,6 +688,7 @@ input.search { .min-h-8 { min-height: 2rem; } .min-h-9 { min-height: 2.25rem; } .min-h-11 { min-height: 2.75rem; } +.min-h-12 { min-height: 3rem; } .min-h-30 { min-height: 7.5rem; } .min-h-60 { min-height: 15rem; } .max-w-2 { max-width: .5rem; } @@ -919,6 +922,7 @@ a.no-line { } .background-body-color { background-color: var(--theme-bg-color); } +.background-bg-accent-color { background-color: var(--theme-bg-accent-color); } .background-accent-bg-color { background-color: var(--accent-bg-color); } .background-highlight-select { background-color: var(--highlight-select); } .background-highlight-red { background-color: var(--highlight-red); } diff --git a/packages/theme/styles/common.scss b/packages/theme/styles/common.scss index 2723514475..2ef3013135 100644 --- a/packages/theme/styles/common.scss +++ b/packages/theme/styles/common.scss @@ -334,13 +334,13 @@ .wrapped-icon, &.wrapped-icon { margin-right: .75rem; - color: var(--content-color); + color: var(--theme-content-color); } .wrapped-title, &.wrapped-title { min-width: 0; font-weight: 500; font-size: 1rem; - color: var(--caption-color); + color: var(--theme-caption-color); overflow: hidden; text-overflow: ellipsis; @@ -349,7 +349,7 @@ .wrapped-subtitle, &.wrapped-subtitle { min-width: 0; font-size: 0.75rem; - color: var(--dark-color); + color: var(--theme-dark-color); overflow: hidden; visibility: visible; @@ -360,7 +360,7 @@ line-clamp: 2; user-select: text; - b { color: var(--content-color); } + b { color: var(--theme-content-color); } } } diff --git a/packages/theme/styles/components.scss b/packages/theme/styles/components.scss index 92c5c62acc..f1d7e044cd 100644 --- a/packages/theme/styles/components.scss +++ b/packages/theme/styles/components.scss @@ -1098,7 +1098,7 @@ } /* Kanban - global style */ -.kanban-container .card-container .antiButton.link-bordered { padding: 0 .5rem; } +.kanban-container .card-container .antiButton.link-bordered { padding: 0 .5rem !important; } .kanban-container .card-container .card-labels > *:not(.labels-container), .kanban-container .card-container .card-labels.labels .labels-container > * { margin: .25rem .25rem 0 0; diff --git a/packages/theme/styles/dialogs.scss b/packages/theme/styles/dialogs.scss index 6f27bd0811..1201bea902 100644 --- a/packages/theme/styles/dialogs.scss +++ b/packages/theme/styles/dialogs.scss @@ -294,3 +294,59 @@ } } } + +/* Dialog */ +.antiDialog { + display: flex; + flex-direction: column; + height: 100%; + min-width: 25rem; + min-height: 0; + background-color: var(--theme-popup-color); + border-radius: .5rem; + + &:not(.fullsize) { + max-width: calc(100vw - 2rem); + border: 1px solid var(--theme-popup-divider); + box-shadow: var(--theme-popup-shadow); + } + &.fullsize { + width: 100%; + height: 100%; + max-width: 100%; + max-height: 100%; + } + + .header { + flex-shrink: 0; + padding: .25rem .5rem; + background-color: var(--theme-popup-header); + border-bottom: 1px solid var(--theme-popup-divider); + border-radius: .5rem .5rem 0 0; + + .title { + flex-grow: 1; + font-size: 1rem; + color: var(--theme-caption-color); + } + } + .content { + display: flex; + flex-direction: column; + flex-grow: 1; + min-width: 0; + min-height: 0; + + &.rounded { border-radius: 0 0 .5rem .5rem; } + } + + .footer { + display: flex; + justify-content: space-between; + align-items: center; + flex-shrink: 0; + padding: .25rem .5rem; + border-top: 1px solid var(--theme-popup-divider); + border-radius: 0 0 .5rem .5rem; + } +} diff --git a/packages/ui/src/components/Dialog.svelte b/packages/ui/src/components/Dialog.svelte index 1e8ce5a36d..c772e958bc 100644 --- a/packages/ui/src/components/Dialog.svelte +++ b/packages/ui/src/components/Dialog.svelte @@ -20,6 +20,7 @@ export let label: IntlString | undefined = undefined export let isFullSize: boolean = false + export let padding: string = '1rem' const dispatch = createEventDispatcher() @@ -27,7 +28,7 @@
{}} use:resizeObserver={() => { @@ -37,10 +38,10 @@
{#if $$slots.utils} @@ -64,7 +65,7 @@ {/if}
-
+
{#if $$slots.footerLeft || $$slots.footerRight} @@ -82,61 +83,3 @@
{/if}
- - diff --git a/plugins/gmail-resources/src/components/Chats.svelte b/plugins/gmail-resources/src/components/Chats.svelte index 86add6b5d5..6047f1262c 100644 --- a/plugins/gmail-resources/src/components/Chats.svelte +++ b/plugins/gmail-resources/src/components/Chats.svelte @@ -94,61 +94,51 @@ } -
-
- {#if selectable} - {selected.size} -
-
-
-
-
-
- {:else} - {#if enabled} -
+ {:else} + {#if enabled}
- - -
- {#if messages && messages.length > 0} - -
{:else} -
- -
-
+
{/if} +
+ +{#if messages && messages.length > 0} +
+ + +
+ +
+{:else} +
+ +
- +{/if} diff --git a/plugins/gmail-resources/src/components/FullMessage.svelte b/plugins/gmail-resources/src/components/FullMessage.svelte index 7debd4cad9..b30ea12413 100644 --- a/plugins/gmail-resources/src/components/FullMessage.svelte +++ b/plugins/gmail-resources/src/components/FullMessage.svelte @@ -57,81 +57,56 @@ $: user = currentMessage.incoming ? currentMessage.receiver : currentMessage.sender -
-
-
-
+
- -
-