wieerwill/platform
1
0
Fork 0
mirror of https://github.com/hcengineering/platform.git synced 2025-04-12 19:30:52 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

UBERF-5650: do not send mention notification if user already notified (#4821)

Browse Source 
Signed-off-by: Kristina Fefelova <kristin.fefelova@gmail.com>
This commit is contained in:
Kristina 2024-02-29 10:31:56 +04:00 committed by GitHub
parent 8e8651aa0a
commit a8351802d1
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 50 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

67
server-plugins/notification-resources/src/index.ts
View File

@ -98,6 +98,10 @@ export async function OnBacklinkCreate (
return []
}
if (sender === receiver) {
return []
}
const backlink = TxProcessor.createDoc2Doc(tx.tx as TxCreateDoc<Backlink>)
if (!hierarchy.isDerived(backlink.backlinkClass, activity.class.ActivityMessage)) {
@ -118,15 +122,9 @@ export async function OnBacklinkCreate (
return []
}
const doc = (await control.findAll(message.attachedToClass, { _id: message.attachedTo }))[0]
if (doc === undefined) {
return []
}
let res: Tx[] = []
const res: Tx[] = []
const collabMixin = hierarchy.as(message as Doc, notification.mixin.Collaborators)
if (collabMixin.collaborators === undefined || !collabMixin.collaborators.includes(receiver._id)) {
const collabTx = control.txFactory.createTxMixin(
message._id,
@ -142,18 +140,45 @@ export async function OnBacklinkCreate (
res.push(collabTx)
}
const messageTx = (
await control.findAll(core.class.TxCollectionCUD, {
'tx.objectId': message._id,
'tx._class': core.class.TxCreateDoc
})
)[0]
return res
}
res = res.concat(
await createCollabDocInfo([receiver._id], control, messageTx.tx, messageTx, doc, [message as ActivityMessage], true)
async function isBacklinkNotified (tx: TxCollectionCUD<Doc, Backlink>, control: TriggerControl): Promise<boolean> {
const receiver = await getPersonAccount(tx.objectId as Ref<Employee>, control)
if (receiver === undefined) {
return false
}
const { hierarchy } = control
const backlink = TxProcessor.createDoc2Doc(tx.tx as TxCreateDoc<Backlink>)
if (!hierarchy.isDerived(backlink.backlinkClass, activity.class.ActivityMessage)) {
return false
}
const exists = await control.findAll(
notification.class.ActivityInboxNotification,
{ attachedTo: backlink.backlinkId as Ref<ActivityMessage>, user: receiver._id },
{ limit: 1 }
)
return res
return exists.length > 0
}
async function isAlreadyNotified (originTx: TxCUD<Doc>, control: TriggerControl): Promise<boolean> {
if (originTx._class !== core.class.TxCollectionCUD) {
return false
}
const hierarchy = control.hierarchy
const isBacklink = await isBacklinkCreated(originTx as TxCollectionCUD<Doc, AttachedDoc>, hierarchy, control)
if (!isBacklink) {
return false
}
return await isBacklinkNotified(originTx as TxCollectionCUD<Doc, Backlink>, control)
}
async function isBacklinkCreated (
@ -983,6 +1008,14 @@ export async function createCollaboratorNotifications (
return []
}
if (activityMessages.length === 0) {
return []
}
if (await isAlreadyNotified(originTx ?? tx, control)) {
return []
}
switch (tx._class) {
case core.class.TxCreateDoc:
return await createCollaboratorDoc(tx as TxCreateDoc<Doc>, control, activityMessages, originTx ?? tx)