From a78ec1bc193f63b0a67c985c00040c319487afa7 Mon Sep 17 00:00:00 2001 From: Andrey Sobolev Date: Sun, 6 Oct 2024 19:23:43 +0700 Subject: [PATCH] UBERF-8368: Fix review/reviewthread sync (#6821) Signed-off-by: Andrey Sobolev --- services/github/pod-github/src/sync/comments.ts | 6 +++--- services/github/pod-github/src/sync/reviewComments.ts | 2 +- services/github/pod-github/src/sync/reviews.ts | 2 +- services/github/pod-github/src/sync/utils.ts | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/services/github/pod-github/src/sync/comments.ts b/services/github/pod-github/src/sync/comments.ts index 5e33bc4a7e..e847f5b1d2 100644 --- a/services/github/pod-github/src/sync/comments.ts +++ b/services/github/pod-github/src/sync/comments.ts @@ -233,7 +233,7 @@ export class CommentSyncManager implements DocSyncManager { objectClass: chunter.class.ChatMessage, external: createdEvent.comment as CommentExternalData, externalVersion: githubExternalSyncVersion, - parent: createdEvent.issue.url, + parent: (createdEvent.issue.url ?? '').toLocaleLowerCase(), lastModified: new Date(createdEvent.comment.updated_at).getTime() }) this.provider.sync() @@ -409,7 +409,7 @@ export class CommentSyncManager implements DocSyncManager { } }) const upd: DocumentUpdate = { - parent: result?.data.html_url?.split('#')?.[0] ?? '', + parent: (result?.data.html_url?.split('#')?.[0] ?? '').toLowerCase(), url: (result?.data.url ?? '').toLowerCase(), external: result?.data as CommentExternalData, current: result?.data, @@ -529,7 +529,7 @@ export class CommentSyncManager implements DocSyncManager { objectClass: chunter.class.ChatMessage, external: comment, externalVersion: githubExternalSyncVersion, - parent: comment.html_url.split('#')?.[0], + parent: (comment.html_url.split('#')?.[0] ?? '').toLowerCase(), repository: repo._id, lastModified }) diff --git a/services/github/pod-github/src/sync/reviewComments.ts b/services/github/pod-github/src/sync/reviewComments.ts index 7dca881622..6c1bb92365 100644 --- a/services/github/pod-github/src/sync/reviewComments.ts +++ b/services/github/pod-github/src/sync/reviewComments.ts @@ -292,7 +292,7 @@ export class ReviewCommentSyncManager implements DocSyncManager { objectClass: github.class.GithubReviewComment, external: externalData, externalVersion: githubExternalSyncVersion, - parent: createdEvent.pull_request.html_url, + parent: (createdEvent.pull_request.html_url ?? '').toLowerCase(), lastModified: new Date(createdEvent.comment.updated_at ?? Date.now()).getTime() }) this.provider.sync() diff --git a/services/github/pod-github/src/sync/reviews.ts b/services/github/pod-github/src/sync/reviews.ts index 4e8115e3d2..e2eb735f9a 100644 --- a/services/github/pod-github/src/sync/reviews.ts +++ b/services/github/pod-github/src/sync/reviews.ts @@ -267,7 +267,7 @@ export class ReviewSyncManager implements DocSyncManager { external: externalData, externalVersion: githubExternalSyncVersion, derivedVersion: '', - parent: createdEvent.pull_request.html_url, + parent: (createdEvent.pull_request.html_url ?? '').toLowerCase(), lastModified: new Date(createdEvent.review.submitted_at ?? Date.now()).getTime() }) } diff --git a/services/github/pod-github/src/sync/utils.ts b/services/github/pod-github/src/sync/utils.ts index 21ba8041d7..b4c69b482b 100644 --- a/services/github/pod-github/src/sync/utils.ts +++ b/services/github/pod-github/src/sync/utils.ts @@ -360,7 +360,7 @@ export async function syncDerivedDocuments ( externalVersion: githubExternalSyncVersion, derivedVersion: '', lastModified: new Date(r.updatedAt ?? r.createdAt).getTime(), - parent: ext.url, + parent: (ext.url ?? '').toLowerCase(), attachedTo: parentDoc._id, ...extra })