From a780fdb952f5abe1678e853af90c152f1abf2c80 Mon Sep 17 00:00:00 2001 From: Andrey Sobolev Date: Fri, 28 Feb 2025 00:13:43 +0700 Subject: [PATCH] Fix failed tests Signed-off-by: Andrey Sobolev --- tests/sanity/tests/model/login-page.ts | 6 ++++-- tests/sanity/tests/workspace/create.spec.ts | 2 +- .../tests/workspace/onboarding-workspace.spec.ts | 6 +++--- .../tests/workspace/workspace-settings.spec.ts | 14 +++++++------- ws-tests/sanity/tests/workspace/archive.spec.ts | 2 +- ws-tests/sanity/tests/workspace/create.spec.ts | 2 +- 6 files changed, 17 insertions(+), 15 deletions(-) diff --git a/tests/sanity/tests/model/login-page.ts b/tests/sanity/tests/model/login-page.ts index 985db07c73..e28578881f 100644 --- a/tests/sanity/tests/model/login-page.ts +++ b/tests/sanity/tests/model/login-page.ts @@ -37,9 +37,11 @@ export class LoginPage { await (await this.page.goto(`${PlatformURI}/login/admin`))?.finished() } - async clickSignUp (): Promise { + async clickSignUp (usePassword: boolean = true): Promise { await this.linkSignUp().click() - await this.signUpWithPassword().click() + if (usePassword) { + await this.signUpWithPassword().click() + } } async clickOnRecover (): Promise { diff --git a/tests/sanity/tests/workspace/create.spec.ts b/tests/sanity/tests/workspace/create.spec.ts index 6561ad2b03..29ab46439e 100644 --- a/tests/sanity/tests/workspace/create.spec.ts +++ b/tests/sanity/tests/workspace/create.spec.ts @@ -89,7 +89,7 @@ test.describe('Workspace tests', () => { const newWorkspaceName = `New Workspace Name - ${generateId(2)}` await loginPage.goto() - await loginPage.clickSignUp() + await loginPage.clickSignUp(false) await signUpPage.signUpPasswordBtn().click() await signUpPage.checkInfo(page, 'Required field First name') diff --git a/tests/sanity/tests/workspace/onboarding-workspace.spec.ts b/tests/sanity/tests/workspace/onboarding-workspace.spec.ts index eb558f0115..3601e4df9d 100644 --- a/tests/sanity/tests/workspace/onboarding-workspace.spec.ts +++ b/tests/sanity/tests/workspace/onboarding-workspace.spec.ts @@ -122,7 +122,7 @@ test.describe.skip('Workspace tests', () => { } const newWorkspaceName = `New Workspace Name - ${generateId(2)}` await loginPage.goto() - await loginPage.linkSignUp().click() + await loginPage.clickSignUp() await signUpPage.signUp(newUser) await selectWorkspacePage.createWorkspace(newWorkspaceName) await leftSideMenuPage.buttonTracker().click() @@ -144,7 +144,7 @@ test.describe.skip('Workspace tests', () => { const newWorkspaceName = `New Workspace Name - ${generateId(2)}` const newWorkspaceName2 = `New Workspace Name - ${generateId(2)}` await loginPage.goto() - await loginPage.linkSignUp().click() + await loginPage.clickSignUp() await signUpPage.signUp(newUser) await selectWorkspacePage.createWorkspace(newWorkspaceName) await api.createWorkspaceWithLogin(newWorkspaceName2, newUser.email, '1234') @@ -166,7 +166,7 @@ test.describe.skip('Workspace tests', () => { const newWorkspaceName = `New Workspace Name - ${generateId(2)}` const newWorkspaceName2 = `New Workspace Name - ${generateId(2)}` await loginPage.goto() - await loginPage.linkSignUp().click() + await loginPage.clickSignUp() await signUpPage.signUp(newUser) await selectWorkspacePage.createWorkspace(newWorkspaceName) await userProfilePage.openProfileMenu() diff --git a/tests/sanity/tests/workspace/workspace-settings.spec.ts b/tests/sanity/tests/workspace/workspace-settings.spec.ts index c74fc2f959..c8750be693 100644 --- a/tests/sanity/tests/workspace/workspace-settings.spec.ts +++ b/tests/sanity/tests/workspace/workspace-settings.spec.ts @@ -39,7 +39,7 @@ test.describe('Workspace tests', () => { } const newWorkspaceName = `New Workspace Name - ${generateId(2)}` await loginPage.goto() - await loginPage.linkSignUp().click() + await loginPage.clickSignUp() await signUpPage.signUp(newUser) await selectWorkspacePage.createWorkspace(newWorkspaceName) await userProfilePage.openProfileMenu() @@ -57,7 +57,7 @@ test.describe('Workspace tests', () => { } const newWorkspaceName = `New Workspace Name - ${generateId(2)}` await loginPage.goto() - await loginPage.linkSignUp().click() + await loginPage.clickSignUp() await signUpPage.signUp(newUser) await selectWorkspacePage.createWorkspace(newWorkspaceName) await userProfilePage.openProfileMenu() @@ -75,7 +75,7 @@ test.describe('Workspace tests', () => { } const newWorkspaceName = `New Workspace Name - ${generateId(2)}` await loginPage.goto() - await loginPage.linkSignUp().click() + await loginPage.clickSignUp() await signUpPage.signUp(newUser) await selectWorkspacePage.createWorkspace(newWorkspaceName) await userProfilePage.openProfileMenu() @@ -97,7 +97,7 @@ test.describe('Workspace tests', () => { const newWorkspaceName = `New Workspace Name - ${generateId(2)}` const newTemplateName = faker.word.words(2) await loginPage.goto() - await loginPage.linkSignUp().click() + await loginPage.clickSignUp() await signUpPage.signUp(newUser) await selectWorkspacePage.createWorkspace(newWorkspaceName) await userProfilePage.openProfileMenu() @@ -115,7 +115,7 @@ test.describe('Workspace tests', () => { } const newWorkspaceName = `New Workspace Name - ${generateId(2)}` await loginPage.goto() - await loginPage.linkSignUp().click() + await loginPage.clickSignUp() await signUpPage.signUp(newUser) await selectWorkspacePage.createWorkspace(newWorkspaceName) await userProfilePage.openProfileMenu() @@ -135,7 +135,7 @@ test.describe('Workspace tests', () => { const enumTitle = faker.word.words(2) const enumName = faker.word.words(2) await loginPage.goto() - await loginPage.linkSignUp().click() + await loginPage.clickSignUp() await signUpPage.signUp(newUser) await selectWorkspacePage.createWorkspace(newWorkspaceName) await userProfilePage.openProfileMenu() @@ -156,7 +156,7 @@ test.describe('Workspace tests', () => { const enumTitle = faker.word.words(2) const enumName = faker.word.words(2) await loginPage.goto() - await loginPage.linkSignUp().click() + await loginPage.clickSignUp() await signUpPage.signUp(newUser) await selectWorkspacePage.createWorkspace(newWorkspaceName) await userProfilePage.openProfileMenu() diff --git a/ws-tests/sanity/tests/workspace/archive.spec.ts b/ws-tests/sanity/tests/workspace/archive.spec.ts index 004e6d24b3..1148df8b9e 100644 --- a/ws-tests/sanity/tests/workspace/archive.spec.ts +++ b/ws-tests/sanity/tests/workspace/archive.spec.ts @@ -98,7 +98,7 @@ test.describe('Workspace Archive tests', () => { await test.step('Check workspace is active again', async () => { await page.reload() - await selectWorkspacePage.selectWorkspace(workspaceInfo.workspaceName) + await selectWorkspacePage.selectWorkspace(workspaceName) const issuesDetailsPage = new IssuesDetailsPage(page) await issuesDetailsPage.checkIssue(newIssue) diff --git a/ws-tests/sanity/tests/workspace/create.spec.ts b/ws-tests/sanity/tests/workspace/create.spec.ts index fd54e33bfe..938d6e9dc9 100644 --- a/ws-tests/sanity/tests/workspace/create.spec.ts +++ b/ws-tests/sanity/tests/workspace/create.spec.ts @@ -94,7 +94,7 @@ test.describe('Workspace tests', () => { const newWorkspaceName = `New Workspace Name - ${generateId(2)}` await loginPage.goto() - await loginPage.clickSignUp() + await loginPage.clickSignUp(false) await signUpPage.signUpPasswordBtn().click() await signUpPage.checkInfo(page, 'Required field First name')