wieerwill/platform
1
0
Fork 0
mirror of https://github.com/hcengineering/platform.git synced 2025-06-09 09:20:54 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

UBER-797: Fix popup menu runtime error (#3627)

Browse Source 
Signed-off-by: Maxim Karmatskikh <mkarmatskih@gmail.com>
This commit is contained in:
Maksim Karmatskikh 2023-08-24 21:44:29 +06:00 committed by GitHub
parent 71b653dcac
commit 9396f7ef20
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
packages/text-editor/src/components/TextEditor.svelte
View File

@ -214,6 +214,13 @@
// I need to copypaste original function and make a little change // I need to copypaste original function and make a little change
// with showContextMenu falg // with showContextMenu falg
shouldShow: ({ editor, view, state, oldState, from, to }) => { shouldShow: ({ editor, view, state, oldState, from, to }) => {
// For some reason shouldShow might be called after dismount and
// after destroing the editor. We should handle this just no to have
// any errors in runtime
if (!element) {
return false
}
const { doc, selection } = state const { doc, selection } = state
const { empty } = selection const { empty } = selection