From 9224a6c8e0c1b883a348210ba3456b2c38aa5fdc Mon Sep 17 00:00:00 2001 From: Denis Bykhov Date: Wed, 12 Apr 2023 19:49:10 +0600 Subject: [PATCH] Fix disabled integration notification (#2962) Signed-off-by: Denis Bykhov --- models/setting/package.json | 1 + models/setting/src/index.ts | 12 +++- models/setting/src/plugin.ts | 6 +- plugins/setting-resources/package.json | 1 + .../src/components/IntegrationPanel.svelte | 72 +++++++++++++++++++ .../TxIntegrationDisableReconnect.svelte | 54 -------------- plugins/setting-resources/src/index.ts | 8 +-- 7 files changed, 91 insertions(+), 63 deletions(-) create mode 100644 plugins/setting-resources/src/components/IntegrationPanel.svelte delete mode 100644 plugins/setting-resources/src/components/activity/TxIntegrationDisableReconnect.svelte diff --git a/models/setting/package.json b/models/setting/package.json index d2bd580fe1..cdf251e398 100644 --- a/models/setting/package.json +++ b/models/setting/package.json @@ -37,6 +37,7 @@ "@hcengineering/model-view": "^0.6.0", "@hcengineering/model-workbench": "^0.6.1", "@hcengineering/task": "^0.6.4", + "@hcengineering/notification": "^0.6.9", "@hcengineering/templates": "^0.6.1", "@hcengineering/activity": "^0.6.0" } diff --git a/models/setting/src/index.ts b/models/setting/src/index.ts index f0797c212d..29c2d03d57 100644 --- a/models/setting/src/index.ts +++ b/models/setting/src/index.ts @@ -33,6 +33,7 @@ import task from '@hcengineering/task' import setting from './plugin' import templates from '@hcengineering/templates' import contact from '@hcengineering/contact' +import notification from '@hcengineering/notification' import workbench from '@hcengineering/model-workbench' import { AnyComponent } from '@hcengineering/ui' @@ -101,6 +102,14 @@ export function createModel (builder: Builder): void { TInviteSettings ) + builder.mixin(setting.class.Integration, core.class.Class, notification.mixin.ClassCollaborators, { + fields: ['modifiedBy'] + }) + + builder.mixin(setting.class.Integration, core.class.Class, view.mixin.ObjectPanel, { + component: setting.component.IntegrationPanel + }) + builder.createDoc( setting.class.SettingsCategory, core.space.Model, @@ -293,8 +302,7 @@ export function createModel (builder: Builder): void { txClass: core.class.TxUpdateDoc, label: setting.string.IntegrationWith, labelComponent: setting.activity.TxIntegrationDisable, - component: setting.activity.TxIntegrationDisableReconnect, - display: 'emphasized', + display: 'inline', editable: false, hideOnRemove: true }, diff --git a/models/setting/src/plugin.ts b/models/setting/src/plugin.ts index a13f7383bb..261d88b772 100644 --- a/models/setting/src/plugin.ts +++ b/models/setting/src/plugin.ts @@ -24,8 +24,7 @@ import { TemplateFieldFunc } from '@hcengineering/templates' export default mergeIds(settingId, setting, { activity: { - TxIntegrationDisable: '' as AnyComponent, - TxIntegrationDisableReconnect: '' as AnyComponent + TxIntegrationDisable: '' as AnyComponent }, ids: { TxIntegrationDisable: '' as Ref, @@ -43,7 +42,8 @@ export default mergeIds(settingId, setting, { Owners: '' as AnyComponent, CreateMixin: '' as AnyComponent, InviteSetting: '' as AnyComponent, - ArrayEditor: '' as AnyComponent + ArrayEditor: '' as AnyComponent, + IntegrationPanel: '' as AnyComponent }, category: { Settings: '' as Ref diff --git a/plugins/setting-resources/package.json b/plugins/setting-resources/package.json index 44a15febac..52d0683d3a 100644 --- a/plugins/setting-resources/package.json +++ b/plugins/setting-resources/package.json @@ -40,6 +40,7 @@ "@hcengineering/attachment": "^0.6.3", "@hcengineering/ui": "^0.6.5", "@hcengineering/presentation": "^0.6.2", + "@hcengineering/panel": "^0.6.3", "@hcengineering/view": "^0.6.3", "@hcengineering/view-resources": "^0.6.0", "@hcengineering/task": "^0.6.4", diff --git a/plugins/setting-resources/src/components/IntegrationPanel.svelte b/plugins/setting-resources/src/components/IntegrationPanel.svelte new file mode 100644 index 0000000000..47f67c59f7 --- /dev/null +++ b/plugins/setting-resources/src/components/IntegrationPanel.svelte @@ -0,0 +1,72 @@ + + + +{#if integration} + +
+ {#if type} + + {/if} +
+
+{/if} diff --git a/plugins/setting-resources/src/components/activity/TxIntegrationDisableReconnect.svelte b/plugins/setting-resources/src/components/activity/TxIntegrationDisableReconnect.svelte deleted file mode 100644 index 567f87dc28..0000000000 --- a/plugins/setting-resources/src/components/activity/TxIntegrationDisableReconnect.svelte +++ /dev/null @@ -1,54 +0,0 @@ - - - -
-
diff --git a/plugins/setting-resources/src/index.ts b/plugins/setting-resources/src/index.ts index 816437a699..0616d06df0 100644 --- a/plugins/setting-resources/src/index.ts +++ b/plugins/setting-resources/src/index.ts @@ -19,7 +19,6 @@ import { getClient, MessageBox } from '@hcengineering/presentation' import { showPopup } from '@hcengineering/ui' import { deleteObject } from '@hcengineering/view-resources/src/utils' import TxIntegrationDisable from './components/activity/TxIntegrationDisable.svelte' -import TxIntegrationDisableReconnect from './components/activity/TxIntegrationDisableReconnect.svelte' import ClassSetting from './components/ClassSetting.svelte' import CreateMixin from './components/CreateMixin.svelte' import EditEnum from './components/EditEnum.svelte' @@ -44,6 +43,7 @@ import StringTypeEditor from './components/typeEditors/StringTypeEditor.svelte' import WorkspaceSettings from './components/WorkspaceSettings.svelte' import InviteSetting from './components/InviteSetting.svelte' import setting from './plugin' +import IntegrationPanel from './components/IntegrationPanel.svelte' import { getOwnerName, getOwnerPosition, getValue } from './utils' export { ClassSetting } @@ -72,8 +72,7 @@ async function DeleteMixin (object: Mixin>): Promise { export default async (): Promise => ({ activity: { - TxIntegrationDisable, - TxIntegrationDisableReconnect + TxIntegrationDisable }, component: { Settings, @@ -98,7 +97,8 @@ export default async (): Promise => ({ EnumSetting, Owners, CreateMixin, - InviteSetting + InviteSetting, + IntegrationPanel }, actionImpl: { DeleteMixin