From 9014020ca7f5fba690e4c696cf4ede718fc306ec Mon Sep 17 00:00:00 2001
From: Alexander Onnikov <aonnikov@hardcoreeng.com>
Date: Mon, 2 Dec 2024 18:25:01 +0700
Subject: [PATCH] fix: optimize json content migration (#7252)

Signed-off-by: Alexander Onnikov <Alexander.Onnikov@xored.com>
---
 models/core/src/migration.ts | 58 +++++++++++++++++-------------------
 1 file changed, 27 insertions(+), 31 deletions(-)

diff --git a/models/core/src/migration.ts b/models/core/src/migration.ts
index e5dfc1e3bc..3e047389d8 100644
--- a/models/core/src/migration.ts
+++ b/models/core/src/migration.ts
@@ -13,7 +13,7 @@
 // limitations under the License.
 //
 
-import { saveCollabJson, saveCollabYdoc, yDocFromBuffer } from '@hcengineering/collaboration'
+import { saveCollabJson } from '@hcengineering/collaboration'
 import core, {
   coreId,
   DOMAIN_MODEL_TX,
@@ -348,10 +348,6 @@ async function processMigrateJsonForDoc (
       ? `${attribute.attributeOf}.${attribute.name}`
       : attribute.name
 
-    // Name of existing ydoc document
-    // original value here looks like '65b7f82f4d422b89d4cbdd6f:HEAD:0'
-    // where the first part is the blob id
-    const currentYdocId = value.split(':')[0] as Ref<Blob>
     const collabId = makeDocCollabId(doc, attribute.name)
 
     if (value.startsWith('{')) {
@@ -361,34 +357,34 @@ async function processMigrateJsonForDoc (
       continue
     }
 
+    if (!value.includes(':')) {
+      // not a collaborative document, skip
+      continue
+    }
+
+    // Name of existing ydoc document
+    // original value here looks like '65b7f82f4d422b89d4cbdd6f:HEAD:0'
+    // where the first part is the blob id
+    const currentYdocId = value.split(':')[0] as Ref<Blob>
+
     try {
-      const stat = await storageAdapter.stat(ctx, workspaceId, currentYdocId)
-      if (stat !== undefined) {
-        if (stat.contentType.includes('application/ydoc')) {
-          const buffer = await storageAdapter.read(ctx, workspaceId, currentYdocId)
-          const ydoc = yDocFromBuffer(Buffer.concat(buffer as any))
-
-          // If document id has changed, save it with new name to ensure we will be able to load it later
-          const ydocId = makeCollabYdocId(collabId)
-          if (ydocId !== currentYdocId) {
-            ctx.info('saving collaborative doc with new name', { collabId, ydocId, currentYdocId })
-            await saveCollabYdoc(ctx, storageAdapter, workspaceId, collabId, ydoc)
-            // do not bother with deletion so we can restore content is something goes wrong
-            // await storageAdapter.remove(ctx, client.workspaceId, [currentYdocId])
-          }
-
-          // Save document as JSON and save blob Id
-          const jsonId = await saveCollabJson(ctx, storageAdapter, workspaceId, collabId, ydoc)
-          update[attributeName] = jsonId
-        } else {
-          // it is not ydoc, do nothing
-          continue
-        }
-      } else {
-        // document is empty, unset
-        const unset = update.$unset ?? {}
-        update.$unset = { ...unset, [attribute.name]: 1 }
+      // If document id has changed, save it with new name to ensure we will be able to load it later
+      const ydocId = makeCollabYdocId(collabId)
+      if (ydocId !== currentYdocId) {
+        ctx.info('saving collaborative doc with new name', { collabId, ydocId, currentYdocId })
+        const buffer = await storageAdapter.read(ctx, workspaceId, currentYdocId)
+        await storageAdapter.put(
+          ctx,
+          workspaceId,
+          ydocId,
+          Buffer.concat(buffer as any),
+          'application/ydoc',
+          buffer.length
+        )
       }
+
+      const unset = update.$unset ?? {}
+      update.$unset = { ...unset, [attribute.name]: 1 }
     } catch (err) {
       ctx.warn('failed to process collaborative doc', { workspaceId, collabId, currentYdocId, err })
     }