From 8bbba7bc8af85e5117d46e8f2f2cb5f21456a7b3 Mon Sep 17 00:00:00 2001
From: Denis Bykhov <bykhov.denis@gmail.com>
Date: Thu, 20 Feb 2025 21:43:19 +0500
Subject: [PATCH] Minor fixes (#8062)

Signed-off-by: Denis Bykhov <bykhov.denis@gmail.com>
---
 plugins/hr-assets/lang/ru.json                |  6 +-
 .../issues/timereport/TimePresenter.svelte    | 61 +++++++++----------
 tests/sanity/tests/tracker/tracker.utils.ts   |  2 +-
 3 files changed, 32 insertions(+), 37 deletions(-)

diff --git a/plugins/hr-assets/lang/ru.json b/plugins/hr-assets/lang/ru.json
index fe24bea6db..323e6f1934 100644
--- a/plugins/hr-assets/lang/ru.json
+++ b/plugins/hr-assets/lang/ru.json
@@ -27,11 +27,11 @@
     "NoEmployeesInDepartment": "Нет сотрудников в выбранном департаменте",
     "Vacation": "Отпуск",
     "Sick": "Больничный",
-    "PTO": "Отпуск",
-    "PTOs": "Отпускных дней",
+    "PTO": "Отгул(PTO)",
+    "PTOs": "Отгулов",
     "Remote": "Удаленно",
     "Overtime": "Переработка",
-    "PTO2": "Отпуск/2",
+    "PTO2": "Отгул(PTO)/2",
     "Overtime2": "Переработка/2",
     "EditRequest": "Редактировать {type}",
     "EditRequestType": "Редактировать тип",
diff --git a/plugins/tracker-resources/src/components/issues/timereport/TimePresenter.svelte b/plugins/tracker-resources/src/components/issues/timereport/TimePresenter.svelte
index cf31db36b4..9364b42829 100644
--- a/plugins/tracker-resources/src/components/issues/timereport/TimePresenter.svelte
+++ b/plugins/tracker-resources/src/components/issues/timereport/TimePresenter.svelte
@@ -13,9 +13,9 @@
 // limitations under the License.
 -->
 <script lang="ts">
-  import { Label, tooltip, themeStore } from '@hcengineering/ui'
+  import { getEmbeddedLabel, translate } from '@hcengineering/platform'
+  import { themeStore, tooltip } from '@hcengineering/ui'
   import tracker from '../../../plugin'
-  import { translate } from '@hcengineering/platform'
 
   export let id: string | undefined = undefined
   export let kind: 'link' | undefined = undefined
@@ -29,31 +29,32 @@
 
   $: days = Math.floor(value / hoursInWorkingDay)
   $: hours = Math.floor(value % hoursInWorkingDay)
-  $: minutes = Math.floor((value % 1) * 60)
+  $: minutes = Math.round((value % 1) * 60)
 
-  $: Promise.all([
-    days > 0 ? translate(tracker.string.TimeSpendDays, { value: days }, $themeStore.language) : Promise.resolve(false),
-    hours > 0
-      ? translate(tracker.string.TimeSpendHours, { value: hours }, $themeStore.language)
-      : Promise.resolve(false),
-    minutes > 0
-      ? translate(tracker.string.TimeSpendMinutes, { value: minutes }, $themeStore.language)
-      : Promise.resolve(false)
-  ])
-    .then(([days, hours, minutes]) =>
-      [
-        ...(days === false ? [] : [days]),
-        ...(hours === false ? [] : [hours]),
-        ...(minutes === false ? [] : [minutes])
-      ].join(' ')
-    )
-    .then((l) => (l === '' ? translate(tracker.string.TimeSpendHours, { value: 0 }, $themeStore.language) : l))
-    .then((l) => {
-      label = l
-    })
-    .catch((err) => {
-      console.error(err)
-    })
+  $: void getLabel(days, hours, minutes, $themeStore.language)
+
+  async function getLabel (days: number, hours: number, minutes: number, language: string): Promise<void> {
+    try {
+      const res: string[] = []
+      if (days > 0) {
+        const d = await translate(tracker.string.TimeSpendDays, { value: days }, language)
+        res.push(d)
+      }
+      if (hours > 0) {
+        const h = await translate(tracker.string.TimeSpendHours, { value: hours }, language)
+        res.push(h)
+      }
+      if (minutes > 0) {
+        const m = await translate(tracker.string.TimeSpendMinutes, { value: minutes }, language)
+        res.push(m)
+      }
+      if (res.length > 0) {
+        label = res.join(' ')
+      } else {
+        label = await translate(tracker.string.TimeSpendHours, { value: 0 }, language)
+      }
+    } catch {}
+  }
 </script>
 
 <!-- svelte-ignore a11y-click-events-have-key-events -->
@@ -63,13 +64,7 @@
   class:link={kind === 'link'}
   class:fs-bold={accent}
   on:click
-  use:tooltip={{
-    component: Label,
-    props: {
-      label: tracker.string.TimeSpendHours,
-      params: { value }
-    }
-  }}
+  use:tooltip={{ label: getEmbeddedLabel(label) }}
 >
   {label}
 </span>
diff --git a/tests/sanity/tests/tracker/tracker.utils.ts b/tests/sanity/tests/tracker/tracker.utils.ts
index 7d87d0f70c..fede06cee5 100644
--- a/tests/sanity/tests/tracker/tracker.utils.ts
+++ b/tests/sanity/tests/tracker/tracker.utils.ts
@@ -294,7 +294,7 @@ export function convertEstimation (estimation: number | string): string {
 
   const days = Math.floor(value / hoursInWorkingDay)
   const hours = Math.floor(value % hoursInWorkingDay)
-  const minutes = Math.floor((value % 1) * 60)
+  const minutes = Math.round((value % 1) * 60)
   const result = [
     ...(days === 0 ? [] : [`${days}d`]),
     ...(hours === 0 ? [] : [`${hours}h`]),