wieerwill/platform
1
0
Fork 0
mirror of https://github.com/hcengineering/platform.git synced 2025-04-29 11:43:49 +00:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

UBERF-9491 Filter out default undefined values from component props (#8052)

Browse Source 
Signed-off-by: Alexander Onnikov <Alexander.Onnikov@xored.com>
This commit is contained in:
Alexander Onnikov 2025-02-19 14:29:18 +07:00 committed by Andrey Sobolev
parent 75c207a822
commit 7e18269f06
No known key found for this signature in database
GPG Key ID: BD80F68D68D8F7F2
1 changed files with 17 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
packages/ui/src/components/Component.svelte
View File

@ -33,11 +33,23 @@
let _is: AnyComponent | AnySvelteComponent = is
let _props: any = props
// See https://github.com/sveltejs/svelte/issues/4068
// When passing undefined prop value, then Svelte uses default value only first time when
// component is instantiated. On the next update the value will be set to undefined.
// Here we filter out undefined values from props on updates to ensure we don't overwrite them.
const filterDefaultUndefined = (pnew: any, pold: any): any =>
pnew != null
? Object.fromEntries(Object.entries(pnew).filter(([k, v]) => v !== undefined || pold?.[k] !== undefined))
: pnew
$: if (!deepEqual(_is, is)) {
_is = is
}
$: if (!deepEqual(_props, props)) {
_props = props
$: {
const p = filterDefaultUndefined(props, _props)
if (!deepEqual(_props, p)) {
_props = p
}
}
let Ctor: any
@ -61,6 +73,7 @@
.then((res) => {
if (current === counter) {
Ctor = res
_props = props
loading = false
}
})
@ -72,9 +85,11 @@
} else {
loading = false
Ctor = component
_props = props
}
} else {
Ctor = _is
_props = props
}
}