wieerwill/platform
1
0
Fork 0
mirror of https://github.com/hcengineering/platform.git synced 2025-06-06 15:57:05 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

fix: destroy hls player on destroy (#7821)
Some checks are pending
CI / build (push) Waiting to run
Details
CI / svelte-check (push) Blocked by required conditions
Details
CI / formatting (push) Blocked by required conditions
Details
CI / test (push) Blocked by required conditions
Details
CI / uitest (push) Waiting to run
Details
CI / uitest-pg (push) Waiting to run
Details
CI / uitest-qms (push) Waiting to run
Details
CI / docker-build (push) Blocked by required conditions
Details
CI / dist-build (push) Blocked by required conditions
Details

Browse Source 
Signed-off-by: Alexander Onnikov <Alexander.Onnikov@xored.com>
This commit is contained in:
Alexander Onnikov 2025-01-29 12:03:13 +07:00 committed by GitHub
parent 9a02b1d430
commit 7ae937461f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
plugins/view-resources/src/components/viewer/VideoViewer.svelte
View File

@ -15,6 +15,7 @@
<script lang="ts"> <script lang="ts">
import { type Blob, type Ref } from '@hcengineering/core' import { type Blob, type Ref } from '@hcengineering/core'
import { getFileUrl, getVideoMeta, type BlobMetadata } from '@hcengineering/presentation' import { getFileUrl, getVideoMeta, type BlobMetadata } from '@hcengineering/presentation'
import { onDestroy } from 'svelte'
import HLS from 'hls.js' import HLS from 'hls.js'
export let value: Ref<Blob> export let value: Ref<Blob>
@ -23,12 +24,14 @@
export let fit: boolean = false export let fit: boolean = false
let video: HTMLVideoElement let video: HTMLVideoElement
let hls: HLS
async function fetchVideoMeta (value: Ref<Blob>, name: string): Promise<void> { async function fetchVideoMeta (value: Ref<Blob>, name: string): Promise<void> {
const src = getFileUrl(value, name) const src = getFileUrl(value, name)
const meta = await getVideoMeta(value, name) const meta = await getVideoMeta(value, name)
if (meta != null && meta.status === 'ready' && HLS.isSupported()) { if (meta != null && meta.status === 'ready' && HLS.isSupported()) {
const hls = new HLS() hls?.destroy()
hls = new HLS()
hls.loadSource(meta.hls) hls.loadSource(meta.hls)
hls.attachMedia(video) hls.attachMedia(video)
video.poster = meta.thumbnail video.poster = meta.thumbnail
@ -37,6 +40,10 @@
} }
} }
onDestroy(() => {
hls?.destroy()
})
$: aspectRatio = $: aspectRatio =
metadata?.originalWidth && metadata?.originalHeight metadata?.originalWidth && metadata?.originalHeight
? `${metadata.originalWidth} / ${metadata.originalHeight}` ? `${metadata.originalWidth} / ${metadata.originalHeight}`