From 6eefe88b6092c6e4fe8b21e2ed2918b582c7f7f4 Mon Sep 17 00:00:00 2001 From: Eduard Aksamitov Date: Fri, 8 Mar 2024 18:29:44 +0300 Subject: [PATCH] UBERF-5886: fix todo reorder on click (#4904) Signed-off-by: Eduard Aksamitov --- .../presentation/src/components/SpaceSelector.svelte | 6 +++--- .../time-resources/src/components/EditToDo.svelte | 12 ++++++++---- 2 files changed, 11 insertions(+), 7 deletions(-) diff --git a/packages/presentation/src/components/SpaceSelector.svelte b/packages/presentation/src/components/SpaceSelector.svelte index 41f7d757ed..8af5f62a97 100644 --- a/packages/presentation/src/components/SpaceSelector.svelte +++ b/packages/presentation/src/components/SpaceSelector.svelte @@ -42,9 +42,9 @@ export let create: ObjectCreate | undefined = undefined const dispatch = createEventDispatcher() - let _space = space - $: if (_space !== space) { - _space = space + let oldSpace = space + $: if (oldSpace !== space) { + oldSpace = space dispatch('change', space) } diff --git a/plugins/time-resources/src/components/EditToDo.svelte b/plugins/time-resources/src/components/EditToDo.svelte index e5b1afb153..fb644fe199 100644 --- a/plugins/time-resources/src/components/EditToDo.svelte +++ b/plugins/time-resources/src/components/EditToDo.svelte @@ -101,9 +101,13 @@ object.visibility = visibility } - async function spaceChange (space: Ref) { - await client.update(object, { attachedSpace: space }) - object.attachedSpace = space + async function spaceChange (space: Space | null) { + const oldSpace = object.attachedSpace ?? undefined + const newSpace = space?._id ?? undefined + if (newSpace !== oldSpace) { + await client.update(object, { attachedSpace: newSpace }) + object.attachedSpace = newSpace + } } @@ -171,7 +175,7 @@ autoSelect={false} readonly={object._class === time.class.ProjectToDo} space={object.attachedSpace} - on:change={(e) => spaceChange(e.detail)} + on:object={(e) => spaceChange(e.detail)} />