wieerwill/platform
1
0
Fork 0
mirror of https://github.com/hcengineering/platform.git synced 2025-04-15 04:49:00 +00:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

UBER-1161: remove async to correctly handle query change (#3951)

Browse Source 
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
This commit is contained in:
Vyacheslav Tumanov 2023-11-07 20:10:01 +05:00 committed by GitHub
parent 3b135f749a
commit 50a5aabc38
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
packages/presentation/src/utils.ts
View File

@ -186,17 +186,17 @@ export class LiveQuery {
// We need to prevent callback with old values to be happening // We need to prevent callback with old values to be happening
// One time refresh in case of client recreation // One time refresh in case of client recreation
this.clientRecreated = false this.clientRecreated = false
void this.doQuery<T>(++this.reqId, _class, query, callback, options) this.doQuery<T>(++this.reqId, _class, query, callback, options)
return true return true
} }
private async doQuery<T extends Doc>( private doQuery<T extends Doc>(
id: number, id: number,
_class: Ref<Class<T>>, _class: Ref<Class<T>>,
query: DocumentQuery<T>, query: DocumentQuery<T>,
callback: (result: FindResult<T>) => void, callback: (result: FindResult<T>) => void,
options: FindOptions<T> | undefined options: FindOptions<T> | undefined
): Promise<void> { ): void {
if (pipeline === undefined) { if (pipeline === undefined) {
// We need remember values to perform refresh. // We need remember values to perform refresh.
this.oldCallback = callback this.oldCallback = callback
@ -206,13 +206,13 @@ export class LiveQuery {
return return
} }
const piplineQuery = await pipeline.subscribe(_class, query, options, () => { const piplineQuery = pipeline.subscribe(_class, query, options, () => {
// Refresh query if pipeline decide it is required. // Refresh query if pipeline decide it is required.
this.refreshClient() this.refreshClient()
}) })
if (id !== this.reqId) { if (id !== this.reqId) {
// If we have one more request after this one, no need to do something. // If we have one more request after this one, no need to do something.
piplineQuery.unsubscribe() void piplineQuery.then((res) => res.unsubscribe())
return return
} }
@ -235,7 +235,7 @@ export class LiveQuery {
) )
this.unsubscribe = () => { this.unsubscribe = () => {
unsub() unsub()
piplineQuery.unsubscribe() void piplineQuery.then((res) => res.unsubscribe())
this.oldCallback = undefined this.oldCallback = undefined
this.oldClass = undefined this.oldClass = undefined
this.oldOptions = undefined this.oldOptions = undefined
@ -251,7 +251,7 @@ export class LiveQuery {
const query = this.oldQuery const query = this.oldQuery
const callback = this.oldCallback const callback = this.oldCallback
const options = this.oldOptions const options = this.oldOptions
void this.doQuery(++this.reqId, _class, query, callback, options) this.doQuery(++this.reqId, _class, query, callback, options)
} }
} }