From 488c46e7d88dcb37f23b77f002ff3fa2c86f401e Mon Sep 17 00:00:00 2001
From: Sergei Ogorelkov <sergei.ogorelkov@icloud.com>
Date: Wed, 10 May 2023 19:45:22 +0400
Subject: [PATCH] [TSK-1374] Restrict "ValueFilter" searchable types (#3148)

Signed-off-by: Sergei Ogorelkov <sergei.ogorelkov@icloud.com>
---
 .../src/components/filter/ValueFilter.svelte  | 34 ++++++++++++-------
 1 file changed, 21 insertions(+), 13 deletions(-)

diff --git a/plugins/view-resources/src/components/filter/ValueFilter.svelte b/plugins/view-resources/src/components/filter/ValueFilter.svelte
index b8a28d6393..f7a0689b3c 100644
--- a/plugins/view-resources/src/components/filter/ValueFilter.svelte
+++ b/plugins/view-resources/src/components/filter/ValueFilter.svelte
@@ -13,7 +13,7 @@
 // limitations under the License.
 -->
 <script lang="ts">
-  import { Class, Doc, FindResult, getObjectValue, Ref, SortingOrder, Space } from '@hcengineering/core'
+  import core, { Class, Doc, FindResult, getObjectValue, Ref, SortingOrder, Space } from '@hcengineering/core'
   import { translate } from '@hcengineering/platform'
   import presentation, { getClient } from '@hcengineering/presentation'
   import ui, { Button, Icon, IconCheck, Label, Loading, resizeObserver, deviceOptionsStore } from '@hcengineering/ui'
@@ -31,6 +31,12 @@
   filter.modes = [view.filter.FilterValueIn, view.filter.FilterValueNin]
   filter.mode = filter.mode === undefined ? filter.modes[0] : filter.mode
 
+  // TODO: remove "TypeString" from search types after
+  // a separate filter for strings is implemented
+  $: isSearchable = [core.class.TypeNumber, core.class.TypeString, core.class.EnumOf].includes(
+    filter.key.attribute.type._class
+  )
+
   const client = getClient()
   const key = { key: filter.key.key }
   const promise = getPresenter(client, filter.key._class, key, key)
@@ -48,7 +54,7 @@
     values.clear()
     realValues.clear()
     const resultQuery =
-      search !== ''
+      isSearchable && search !== ''
         ? {
             [filter.key.key]: { $like: '%' + search + '%' }
           }
@@ -124,17 +130,19 @@
 </script>
 
 <div class="selectPopup" use:resizeObserver={() => dispatch('changeContent')}>
-  <div class="header">
-    <input
-      bind:this={searchInput}
-      type="text"
-      bind:value={search}
-      on:change={() => {
-        getValues(search)
-      }}
-      placeholder={phTraslate}
-    />
-  </div>
+  {#if isSearchable}
+    <div class="header">
+      <input
+        bind:this={searchInput}
+        type="text"
+        bind:value={search}
+        on:change={() => {
+          getValues(search)
+        }}
+        placeholder={phTraslate}
+      />
+    </div>
+  {/if}
   <div class="scroll">
     <div class="box">
       {#await promise then attribute}