wieerwill/platform
1
0
Fork 0
mirror of https://github.com/hcengineering/platform.git synced 2025-06-02 13:52:40 +00:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

UBERF-8120: Fix high CPU usage in github service (#6573)

Browse Source 
Signed-off-by: Andrey Sobolev <haiodo@gmail.com>
This commit is contained in:
Andrey Sobolev 2024-09-16 11:52:05 +07:00 committed by GitHub
parent 9095853f7b
commit 310f18c3ff
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
7 changed files with 16 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
services/github/pod-github/src/sync/comments.ts
View File

@ -248,7 +248,7 @@ export class CommentSyncManager implements DocSyncManager {
): Promise<DocumentUpdate<DocSyncInfo> | undefined> { ): Promise<DocumentUpdate<DocSyncInfo> | undefined> {
const container = await this.provider.getContainer(info.space) const container = await this.provider.getContainer(info.space)
if (container?.container === undefined) { if (container?.container === undefined) {
return {} return { needSync: githubSyncVersion }
} }
if (info.external === undefined) { if (info.external === undefined) {
// TODO: Use selected repository // TODO: Use selected repository

8
services/github/pod-github/src/sync/issues.ts
View File

@ -325,11 +325,13 @@ export class IssueSyncManager extends IssueSyncManagerBase implements DocSyncMan
derivedClient: TxOperations derivedClient: TxOperations
): Promise<DocumentUpdate<DocSyncInfo> | undefined> { ): Promise<DocumentUpdate<DocSyncInfo> | undefined> {
const container = await this.provider.getContainer(info.space) const container = await this.provider.getContainer(info.space)
if (container?.container === undefined) {
return { needSync: githubSyncVersion }
}
if ( if (
container?.container === undefined || (container.project.projectNodeId === undefined ||
((container.project.projectNodeId === undefined ||
!container.container.projectStructure.has(container.project._id)) && !container.container.projectStructure.has(container.project._id)) &&
syncConfig.MainProject) syncConfig.MainProject
) { ) {
this.ctx.error('Not syncing no structure', { url: info.url }) this.ctx.error('Not syncing no structure', { url: info.url })
return { needSync: '' } return { needSync: '' }

2
services/github/pod-github/src/sync/projects.ts
View File

@ -103,7 +103,7 @@ export class ProjectsSyncManager implements DocSyncManager {
): Promise<DocumentUpdate<DocSyncInfo> | undefined> { ): Promise<DocumentUpdate<DocSyncInfo> | undefined> {
const container = await this.provider.getContainer(info.space) const container = await this.provider.getContainer(info.space)
if (container?.container === undefined) { if (container?.container === undefined) {
return {} return { needSync: githubSyncVersion }
} }
const okit = await this.provider.getOctokit(container.project.createdBy as Ref<PersonAccount>) const okit = await this.provider.getOctokit(container.project.createdBy as Ref<PersonAccount>)

10
services/github/pod-github/src/sync/pullrequests.ts
View File

@ -957,13 +957,15 @@ export class PullRequestSyncManager extends IssueSyncManagerBase implements DocS
derivedClient: TxOperations derivedClient: TxOperations
): Promise<DocumentUpdate<DocSyncInfo> | undefined> { ): Promise<DocumentUpdate<DocSyncInfo> | undefined> {
const container = await this.provider.getContainer(info.space) const container = await this.provider.getContainer(info.space)
if (container?.container === undefined) {
return { needSync: githubSyncVersion }
}
if ( if (
container?.container === undefined || (container.project.projectNodeId === undefined ||
((container.project.projectNodeId === undefined ||
!container.container.projectStructure.has(container.project._id)) && !container.container.projectStructure.has(container.project._id)) &&
syncConfig.MainProject) syncConfig.MainProject
) { ) {
return { needSync: '' } return { needSync: githubSyncVersion }
} }
const pullRequestExternal = info.external as unknown as PullRequestExternalData const pullRequestExternal = info.external as unknown as PullRequestExternalData

2
services/github/pod-github/src/sync/reviewComments.ts
View File

@ -307,7 +307,7 @@ export class ReviewCommentSyncManager implements DocSyncManager {
): Promise<DocumentUpdate<DocSyncInfo> | undefined> { ): Promise<DocumentUpdate<DocSyncInfo> | undefined> {
const container = await this.provider.getContainer(info.space) const container = await this.provider.getContainer(info.space)
if (container?.container === undefined) { if (container?.container === undefined) {
return {} return { needSync: githubSyncVersion }
} }
if (parent === undefined) { if (parent === undefined) {
return { needSync: githubSyncVersion } return { needSync: githubSyncVersion }

2
services/github/pod-github/src/sync/reviewThreads.ts
View File

@ -263,7 +263,7 @@ export class ReviewThreadSyncManager implements DocSyncManager {
): Promise<DocumentUpdate<DocSyncInfo> | undefined> { ): Promise<DocumentUpdate<DocSyncInfo> | undefined> {
const container = await this.provider.getContainer(info.space) const container = await this.provider.getContainer(info.space)
if (container?.container === undefined) { if (container?.container === undefined) {
return {} return { needSync: githubSyncVersion }
} }
if (parent === undefined) { if (parent === undefined) {
return { needSync: githubSyncVersion } return { needSync: githubSyncVersion }

2
services/github/pod-github/src/sync/reviews.ts
View File

@ -281,7 +281,7 @@ export class ReviewSyncManager implements DocSyncManager {
): Promise<DocumentUpdate<DocSyncInfo> | undefined> { ): Promise<DocumentUpdate<DocSyncInfo> | undefined> {
const container = await this.provider.getContainer(info.space) const container = await this.provider.getContainer(info.space)
if (container?.container === undefined) { if (container?.container === undefined) {
return {} return { needSync: githubSyncVersion }
} }
if (parent === undefined) { if (parent === undefined) {
return { needSync: githubSyncVersion } return { needSync: githubSyncVersion }