From 20b4854dcccec2af5b34a9de5c49960c37a1b9c7 Mon Sep 17 00:00:00 2001
From: Vyacheslav Tumanov <me@slavatumanov.me>
Date: Tue, 20 Feb 2024 00:13:54 +0500
Subject: [PATCH] proper constructor for SvelteNodeView (#4709)

Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
---
 .../node-view/svelte-node-view-renderer.ts      | 17 +++++++++++------
 1 file changed, 11 insertions(+), 6 deletions(-)

diff --git a/packages/text-editor/src/components/node-view/svelte-node-view-renderer.ts b/packages/text-editor/src/components/node-view/svelte-node-view-renderer.ts
index 247f4bf4e3..0d8655b17a 100644
--- a/packages/text-editor/src/components/node-view/svelte-node-view-renderer.ts
+++ b/packages/text-editor/src/components/node-view/svelte-node-view-renderer.ts
@@ -19,7 +19,8 @@ import {
   NodeView,
   type NodeViewProps,
   type NodeViewRenderer,
-  type NodeViewRendererOptions
+  type NodeViewRendererOptions,
+  type NodeViewRendererProps
 } from '@tiptap/core'
 import type { Node as ProseMirrorNode } from '@tiptap/pm/model'
 import type { ComponentType, SvelteComponent } from 'svelte'
@@ -43,13 +44,18 @@ export type SvelteNodeViewComponent = typeof SvelteComponent | ComponentType
  * https://tiptap.dev/guide/node-views/react/
  */
 class SvelteNodeView extends NodeView<SvelteNodeViewComponent, Editor, SvelteNodeViewRendererOptions> {
-  renderer!: SvelteRenderer
+  private readonly renderer!: SvelteRenderer
 
-  contentDOMElement!: HTMLElement | null
+  private contentDOMElement!: HTMLElement | null
 
-  isEditable!: boolean
+  private isEditable!: boolean
 
-  override mount (): void {
+  constructor (
+    component: SvelteNodeViewComponent,
+    prop: NodeViewRendererProps,
+    options?: Partial<SvelteNodeViewRendererOptions>
+  ) {
+    super(component, prop, options)
     const props: SvelteNodeViewProps = {
       editor: this.editor,
       node: this.node,
@@ -83,7 +89,6 @@ class SvelteNodeView extends NodeView<SvelteNodeViewComponent, Editor, SvelteNod
     })
 
     this.renderer = new SvelteRenderer(this.component, { element: target, props, context })
-
     this.editor.on('update', this.handleEditorUpdate.bind(this))
   }