From 14104a098493c2464e5da75f1f56b0740bfd7c9c Mon Sep 17 00:00:00 2001 From: Vyacheslav Tumanov Date: Fri, 18 Aug 2023 06:29:57 +0500 Subject: [PATCH] UBER-749: fix no label for unassigned (#3603) --- models/tracker/src/index.ts | 2 +- .../contact-resources/src/components/PersonContent.svelte | 5 ----- .../contact-resources/src/components/PersonPresenter.svelte | 3 ++- .../src/components/PersonRefPresenter.svelte | 2 +- 4 files changed, 4 insertions(+), 8 deletions(-) diff --git a/models/tracker/src/index.ts b/models/tracker/src/index.ts index 6e8865604f..b32dbf47f0 100644 --- a/models/tracker/src/index.ts +++ b/models/tracker/src/index.ts @@ -648,7 +648,7 @@ export function createModel (builder: Builder): void { { key: 'assignee', presenter: tracker.component.AssigneeEditor, - displayProps: { key: 'assigee', fixed: 'right' }, + displayProps: { key: 'assignee', fixed: 'right' }, props: { kind: 'list', shouldShowName: false, avatarSize: 'x-small' } } ] diff --git a/plugins/contact-resources/src/components/PersonContent.svelte b/plugins/contact-resources/src/components/PersonContent.svelte index 5f78199eb1..fe2a8070fc 100644 --- a/plugins/contact-resources/src/components/PersonContent.svelte +++ b/plugins/contact-resources/src/components/PersonContent.svelte @@ -118,11 +118,6 @@ - {#if statusLabel} - - - {/if} {/if} {/if} diff --git a/plugins/contact-resources/src/components/PersonPresenter.svelte b/plugins/contact-resources/src/components/PersonPresenter.svelte index 571061ca3d..bf0fe379ca 100644 --- a/plugins/contact-resources/src/components/PersonPresenter.svelte +++ b/plugins/contact-resources/src/components/PersonPresenter.svelte @@ -20,6 +20,7 @@ import PersonContent from './PersonContent.svelte' import { getClient } from '@hcengineering/presentation' import { Ref } from '@hcengineering/core' + import ui from '@hcengineering/ui' export let value: Ref | Person | null | undefined export let inline = false @@ -28,7 +29,7 @@ export let shouldShowAvatar = true export let shouldShowName = true export let shouldShowPlaceholder = false - export let defaultName: IntlString | undefined = undefined + export let defaultName: IntlString | undefined = ui.string.NotSelected export let statusLabel: IntlString | undefined = undefined export let tooltipLabels: PersonLabelTooltip | undefined = undefined export let avatarSize: IconSize = 'x-small' diff --git a/plugins/contact-resources/src/components/PersonRefPresenter.svelte b/plugins/contact-resources/src/components/PersonRefPresenter.svelte index 5f05b77d05..8ffb1b3748 100644 --- a/plugins/contact-resources/src/components/PersonRefPresenter.svelte +++ b/plugins/contact-resources/src/components/PersonRefPresenter.svelte @@ -28,7 +28,7 @@ export let accent: boolean = false export let shouldShowAvatar = true export let shouldShowName = true - export let shouldShowPlaceholder = false + export let shouldShowPlaceholder = true export let defaultName: IntlString | undefined = undefined export let tooltipLabels: PersonLabelTooltip | undefined = undefined export let avatarSize: 'inline' | 'tiny' | 'x-small' | 'small' | 'medium' | 'large' | 'x-large' = 'x-small'