Update context menu in the "CreateIssue" dialog (#1799)

Signed-off-by: Sergei Ogorelkov <sergei.ogorelkov@xored.com>
This commit is contained in:
Sergei Ogorelkov 2022-05-19 17:37:14 +07:00 committed by GitHub
parent fa22aa5f7e
commit 06254e720f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
9 changed files with 144 additions and 55 deletions

View File

@ -439,4 +439,34 @@ export function createModel (builder: Builder): void {
mode: ['workbench', 'browser', 'editor', 'panel', 'popup'] mode: ['workbench', 'browser', 'editor', 'panel', 'popup']
} }
}) })
builder.createDoc(
view.class.ActionCategory,
core.space.Model,
{ label: tracker.string.TrackerApplication, visible: true },
tracker.category.Tracker
)
createAction(
builder,
{
action: view.actionImpl.ShowPopup,
actionProps: {
component: tracker.component.SetDueDateActionPopup,
props: { mondayStart: true, withTime: false },
element: 'top'
},
label: tracker.string.SetDueDate,
icon: tracker.icon.DueDate,
keyBinding: [],
input: 'none',
category: tracker.category.Tracker,
target: tracker.class.Issue,
context: {
mode: ['context', 'browser'],
application: tracker.app.Tracker
}
},
tracker.action.SetDueDate
)
} }

View File

@ -73,6 +73,7 @@
"Project": "Project", "Project": "Project",
"Space": "", "Space": "",
"SetDueDate": "Set due date\u2026", "SetDueDate": "Set due date\u2026",
"ChangeDueDate": "Change due date\u2026",
"ModificationDate": "Updated {value}", "ModificationDate": "Updated {value}",
"Team": "", "Team": "",
"Issue": "", "Issue": "",

View File

@ -32,7 +32,6 @@ loadMetadata(tracker.icon, {
Magnifier: `${icons}#magnifier`, Magnifier: `${icons}#magnifier`,
Home: `${icons}#home`, Home: `${icons}#home`,
Labels: `${icons}#priority-nopriority`, // TODO: add icon Labels: `${icons}#priority-nopriority`, // TODO: add icon
MoreActions: `${icons}#priority-nopriority`, // TODO: add icon
DueDate: `${icons}#inbox`, // TODO: add icon DueDate: `${icons}#inbox`, // TODO: add icon
Parent: `${icons}#myissues`, // TODO: add icon Parent: `${icons}#myissues`, // TODO: add icon

View File

@ -15,7 +15,6 @@
<script lang="ts"> <script lang="ts">
import contact, { Employee } from '@anticrm/contact' import contact, { Employee } from '@anticrm/contact'
import core, { Data, generateId, Ref, SortingOrder, WithLookup } from '@anticrm/core' import core, { Data, generateId, Ref, SortingOrder, WithLookup } from '@anticrm/core'
import { Asset, IntlString } from '@anticrm/platform'
import presentation, { Card, createQuery, getClient, SpaceSelector, UserBox } from '@anticrm/presentation' import presentation, { Card, createQuery, getClient, SpaceSelector, UserBox } from '@anticrm/presentation'
import { StyledTextBox } from '@anticrm/text-editor' import { StyledTextBox } from '@anticrm/text-editor'
import { calcRank, Issue, IssuePriority, IssueStatus, Project, Team } from '@anticrm/tracker' import { calcRank, Issue, IssuePriority, IssueStatus, Project, Team } from '@anticrm/tracker'
@ -23,10 +22,13 @@
Button, Button,
DatePresenter, DatePresenter,
EditBox, EditBox,
eventToHTMLElement,
IconAttachment, IconAttachment,
SelectPopup, showPopup,
showPopup Spinner,
IconMoreH,
ActionIcon,
DatePopup,
Menu
} from '@anticrm/ui' } from '@anticrm/ui'
import { createEventDispatcher } from 'svelte' import { createEventDispatcher } from 'svelte'
import tracker from '../plugin' import tracker from '../plugin'
@ -42,7 +44,7 @@
export let project: Ref<Project> | null = null export let project: Ref<Project> | null = null
let currentAssignee: Ref<Employee> | null = assignee let currentAssignee: Ref<Employee> | null = assignee
let issueStatuses: WithLookup<IssueStatus>[] = [] let issueStatuses: WithLookup<IssueStatus>[] | undefined
let object: Data<Issue> = { let object: Data<Issue> = {
title: '', title: '',
@ -65,21 +67,13 @@
$: _space = space $: _space = space
$: _parent = parent $: _parent = parent
$: updateIssueStatusId(space, status) $: updateIssueStatusId(space, status)
$: statusesQuery.query(
tracker.class.IssueStatus,
{ attachedTo: space },
(statuses) => {
issueStatuses = statuses
},
{
lookup: { category: tracker.class.IssueStatusCategory },
sort: { rank: SortingOrder.Ascending }
}
)
$: canSave = getTitle(object.title ?? '').length > 0 $: canSave = getTitle(object.title ?? '').length > 0
$: statusesQuery.query(tracker.class.IssueStatus, { attachedTo: space }, (statuses) => (issueStatuses = statuses), {
lookup: { category: tracker.class.IssueStatusCategory },
sort: { rank: SortingOrder.Ascending }
})
async function updateIssueStatusId (teamId: Ref<Team>, issueStatusId?: Ref<IssueStatus>) { async function updateIssueStatusId (teamId: Ref<Team>, issueStatusId?: Ref<IssueStatus>) {
if (issueStatusId !== undefined) { if (issueStatusId !== undefined) {
object.status = issueStatusId object.status = issueStatusId
@ -143,10 +137,31 @@
await client.createDoc(tracker.class.Issue, _space, value, taskId) await client.createDoc(tracker.class.Issue, _space, value, taskId)
} }
const moreActions: Array<{ icon: Asset; label: IntlString }> = [ async function showMoreActions (ev: Event) {
{ icon: tracker.icon.DueDate, label: tracker.string.SetDueDate }, ev.preventDefault()
{ icon: tracker.icon.Parent, label: tracker.string.Parent }
] const selectDueDate = {
label: object.dueDate === null ? tracker.string.SetDueDate : tracker.string.ChangeDueDate,
icon: tracker.icon.DueDate,
action: async () => {
showPopup(
DatePopup,
{ mondayStart: true, withTime: false, currentDate: object.dueDate },
undefined,
undefined,
(newDueDate) => newDueDate !== undefined && (object.dueDate = newDueDate)
)
}
}
showPopup(
Menu,
{
actions: [selectDueDate]
},
ev.target as HTMLElement
)
}
const handlePriorityChanged = (newPriority: IssuePriority | undefined) => { const handlePriorityChanged = (newPriority: IssuePriority | undefined) => {
if (newPriority === undefined) { if (newPriority === undefined) {
@ -210,34 +225,32 @@
placeholder={tracker.string.IssueDescriptionPlaceholder} placeholder={tracker.string.IssueDescriptionPlaceholder}
/> />
<svelte:fragment slot="pool"> <svelte:fragment slot="pool">
<StatusSelector selectedStatusId={object.status} statuses={issueStatuses} onStatusChange={handleStatusChanged} /> {#if issueStatuses}
<PrioritySelector priority={object.priority} onPriorityChange={handlePriorityChanged} /> <StatusSelector selectedStatusId={object.status} statuses={issueStatuses} onStatusChange={handleStatusChanged} />
<UserBox <PrioritySelector priority={object.priority} onPriorityChange={handlePriorityChanged} />
_class={contact.class.Employee} <UserBox
label={tracker.string.Assignee} _class={contact.class.Employee}
placeholder={tracker.string.AssignTo} label={tracker.string.Assignee}
bind:value={currentAssignee} placeholder={tracker.string.AssignTo}
allowDeselect bind:value={currentAssignee}
titleDeselect={tracker.string.Unassigned} allowDeselect
/> titleDeselect={tracker.string.Unassigned}
<Button />
label={tracker.string.Labels} <Button
icon={tracker.icon.Labels} label={tracker.string.Labels}
width="min-content" icon={tracker.icon.Labels}
size="small" width="min-content"
kind="no-border" size="small"
/> kind="no-border"
<ProjectSelector value={object.project} onProjectIdChange={handleProjectIdChanged} /> />
<DatePresenter bind:value={object.dueDate} editable /> <ProjectSelector value={object.project} onProjectIdChange={handleProjectIdChanged} />
<Button {#if object.dueDate !== null}
icon={tracker.icon.MoreActions} <DatePresenter bind:value={object.dueDate} editable />
width="min-content" {/if}
size="small" <ActionIcon icon={IconMoreH} size={'medium'} action={showMoreActions} />
kind="transparent" {:else}
on:click={(ev) => { <Spinner size="small" />
showPopup(SelectPopup, { value: moreActions }, eventToHTMLElement(ev)) {/if}
}}
/>
</svelte:fragment> </svelte:fragment>
<svelte:fragment slot="footer"> <svelte:fragment slot="footer">
<Button icon={IconAttachment} kind={'transparent'} on:click={() => {}} /> <Button icon={IconAttachment} kind={'transparent'} on:click={() => {}} />

View File

@ -0,0 +1,36 @@
<!--
// Copyright © 2022 Hardcore Engineering Inc.
//
// Licensed under the Eclipse Public License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License. You may
// obtain a copy of the License at https://www.eclipse.org/legal/epl-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
//
// See the License for the specific language governing permissions and
// limitations under the License.
-->
<script lang="ts">
import { Timestamp } from '@anticrm/core'
import { DatePopup } from '@anticrm/ui'
import { getClient } from '@anticrm/presentation'
import { Issue } from '@anticrm/tracker'
export let value: Issue
export let mondayStart = true
export let withTime = false
const client = getClient()
async function onUpdate ({ detail: newDate }: CustomEvent<Timestamp | undefined>) {
if (newDate !== undefined && newDate !== value.dueDate) {
await client.update(value, { dueDate: newDate })
}
}
$: currentDate = value.dueDate !== null ? new Date(value.dueDate) : null
</script>
<DatePopup {currentDate} {mondayStart} {withTime} on:close on:update={onUpdate} />

View File

@ -34,6 +34,7 @@ import PriorityEditor from './components/issues/PriorityEditor.svelte'
import ProjectEditor from './components/projects/ProjectEditor.svelte' import ProjectEditor from './components/projects/ProjectEditor.svelte'
import StatusPresenter from './components/issues/StatusPresenter.svelte' import StatusPresenter from './components/issues/StatusPresenter.svelte'
import StatusEditor from './components/issues/StatusEditor.svelte' import StatusEditor from './components/issues/StatusEditor.svelte'
import SetDueDateActionPopup from './components/SetDueDateActionPopup.svelte'
import DueDatePresenter from './components/issues/DueDatePresenter.svelte' import DueDatePresenter from './components/issues/DueDatePresenter.svelte'
import AssigneePresenter from './components/issues/AssigneePresenter.svelte' import AssigneePresenter from './components/issues/AssigneePresenter.svelte'
import ViewOptionsPopup from './components/issues/ViewOptionsPopup.svelte' import ViewOptionsPopup from './components/issues/ViewOptionsPopup.svelte'
@ -77,6 +78,7 @@ export default async (): Promise<Resources> => ({
LeadPresenter, LeadPresenter,
TargetDatePresenter, TargetDatePresenter,
ProjectMembersPresenter, ProjectMembersPresenter,
ProjectStatusPresenter ProjectStatusPresenter,
SetDueDateActionPopup
} }
}) })

View File

@ -12,7 +12,6 @@
// See the License for the specific language governing permissions and // See the License for the specific language governing permissions and
// limitations under the License. // limitations under the License.
// //
import type { IntlString } from '@anticrm/platform' import type { IntlString } from '@anticrm/platform'
import { mergeIds } from '@anticrm/platform' import { mergeIds } from '@anticrm/platform'
import tracker, { trackerId } from '../../tracker/lib' import tracker, { trackerId } from '../../tracker/lib'
@ -95,6 +94,7 @@ export default mergeIds(trackerId, tracker, {
Labels: '' as IntlString, Labels: '' as IntlString,
Space: '' as IntlString, Space: '' as IntlString,
SetDueDate: '' as IntlString, SetDueDate: '' as IntlString,
ChangeDueDate: '' as IntlString,
ModificationDate: '' as IntlString, ModificationDate: '' as IntlString,
Issue: '' as IntlString, Issue: '' as IntlString,
Document: '' as IntlString, Document: '' as IntlString,
@ -173,6 +173,7 @@ export default mergeIds(trackerId, tracker, {
LeadPresenter: '' as AnyComponent, LeadPresenter: '' as AnyComponent,
TargetDatePresenter: '' as AnyComponent, TargetDatePresenter: '' as AnyComponent,
ProjectMembersPresenter: '' as AnyComponent, ProjectMembersPresenter: '' as AnyComponent,
ProjectStatusPresenter: '' as AnyComponent ProjectStatusPresenter: '' as AnyComponent,
SetDueDateActionPopup: '' as AnyComponent
} }
}) })

View File

@ -29,6 +29,7 @@
"@anticrm/core": "~0.6.16", "@anticrm/core": "~0.6.16",
"@anticrm/platform": "~0.6.6", "@anticrm/platform": "~0.6.6",
"@anticrm/ui": "~0.6.0", "@anticrm/ui": "~0.6.0",
"@anticrm/view": "~0.6.0",
"@anticrm/contact": "~0.6.5", "@anticrm/contact": "~0.6.5",
"@anticrm/chunter": "~0.6.1", "@anticrm/chunter": "~0.6.1",
"@anticrm/attachment": "~0.6.1", "@anticrm/attachment": "~0.6.1",

View File

@ -15,6 +15,7 @@
import { Employee } from '@anticrm/contact' import { Employee } from '@anticrm/contact'
import type { AttachedDoc, Class, Doc, Markup, Ref, Space, Timestamp, Type } from '@anticrm/core' import type { AttachedDoc, Class, Doc, Markup, Ref, Space, Timestamp, Type } from '@anticrm/core'
import { Action, ActionCategory } from '@anticrm/view'
import type { Asset, IntlString, Plugin } from '@anticrm/platform' import type { Asset, IntlString, Plugin } from '@anticrm/platform'
import { plugin } from '@anticrm/platform' import { plugin } from '@anticrm/platform'
import { AnyComponent } from '@anticrm/ui' import { AnyComponent } from '@anticrm/ui'
@ -213,7 +214,6 @@ export default plugin(trackerId, {
Magnifier: '' as Asset, Magnifier: '' as Asset,
Home: '' as Asset, Home: '' as Asset,
Labels: '' as Asset, Labels: '' as Asset,
MoreActions: '' as Asset,
DueDate: '' as Asset, DueDate: '' as Asset,
Parent: '' as Asset, Parent: '' as Asset,
@ -239,5 +239,11 @@ export default plugin(trackerId, {
ProjectStatusPaused: '' as Asset, ProjectStatusPaused: '' as Asset,
ProjectStatusCompleted: '' as Asset, ProjectStatusCompleted: '' as Asset,
ProjectStatusCanceled: '' as Asset ProjectStatusCanceled: '' as Asset
},
category: {
Tracker: '' as Ref<ActionCategory>
},
action: {
SetDueDate: '' as Ref<Action>
} }
}) })